Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deserialization error of FieldEntry when the 'options' field … #1199

Merged

Conversation

azerowall
Copy link
Contributor

Currently, FieldEntry deserialization is done manually by using a custom deserializer. During the parsing process, if the "options" field appears before the "type" field, an error will occur.
Example of json on which the error occurs:

{
  "name": "title",
  "options": {
    "indexing": {
      "record": "position",
      "tokenizer": "default"
    },
    "stored": false
  },
  "type": "text"
}

This pull request changes the custom serializer to serde_derive macro, which fixes the described error.

@fulmicoton
Copy link
Collaborator

Thank you!

@fulmicoton fulmicoton merged commit fcff915 into quickwit-oss:main Nov 10, 2021
@azerowall azerowall deleted the fix-fieldentry-deserialization-error branch November 10, 2021 11:04
@azerowall azerowall restored the fix-fieldentry-deserialization-error branch November 10, 2021 11:05
@azerowall azerowall deleted the fix-fieldentry-deserialization-error branch November 10, 2021 11:11
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants