Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delta position in merge and index sorting #1132

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Aug 3, 2021

fixes #1125

@PSeitz PSeitz requested review from fulmicoton and appaquet August 3, 2021 08:04
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1132 (96a2239) into main (85d23e8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   89.47%   89.51%   +0.04%     
==========================================
  Files         203      203              
  Lines       20206    20256      +50     
==========================================
+ Hits        18079    18133      +54     
+ Misses       2127     2123       -4     
Impacted Files Coverage Δ
src/indexer/merger.rs 89.56% <100.00%> (+<0.01%) ⬆️
src/indexer/merger_sorted_index_test.rs 100.00% <100.00%> (ø)
src/indexer/segment_updater.rs 88.73% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d23e8...96a2239. Read the comment docs.

@fulmicoton fulmicoton merged commit 4a320fd into main Aug 3, 2021
@fulmicoton fulmicoton deleted the merge_overflow branch August 3, 2021 09:06
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in merge thread
2 participants