Don't use overly-minimal dependencies #1037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get the crates ecosystem to work with
-Z minimal-versions
Cargo option, but many crates incorrectly specify required versions of their dependencies, includingtantivy
.tantivy
doesn't actually work with the versions of dependencies it specifies, and relies on them being implicitly upgraded to latest.If actually old deps are used as specified in
Cargo.toml
, tantivy won't compile:I've upgraded all deps, because many of them have their own problems (especially in their older versions), and
tantivy
isn't tested in CI with minimal versions (it's impractical in the current state of the ecosystem), so it can't guarantee that old versions will remain to work.