Capping IndexWriter Num thread #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
May 6, 2021
src/core/index.rs
Outdated
| @@ -441,7 +442,7 @@ impl Index { | |||
| /// # Panics | |||
| /// If the heap size per thread is too small, panics. | |||
| pub fn writer(&self, overall_heap_size_in_bytes: usize) -> crate::Result<IndexWriter> { | |||
| let mut num_threads = num_cpus::get(); | |||
| let mut num_threads = std::cmp::max(num_cpus::get(), MAX_NUM_THREAD); | |||
There was a problem hiding this comment.
you meant min i believe.
evanxg852000
force-pushed
the
fix-issues-1032
branch
from
3a90bb4 to
236c8ee
Compare
This was referenced Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added small changes for capping index writer number of thread to a maximum of 8.
Issue Link