-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add benchmark of term streams merge #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
Thanks for the comments ! |
@scampi apologies for the late reaction. I actually wrote the comments 3 weeks ago but forgot to hit the send review button >.< |
If you have trouble with rebase, I can do it... Let me know once you addressed the comments |
@fulmicoton see commit 27b29d6 with a possible term merger implementation based on the FST union.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! LGTM
@scampi Thanks it is a very valuable PR for tantivy. Can you add an extra commit to update CHANGELOG.md with your contribution? |
@fulmicoton Please see commit 66b633a with changelog update |
@scampi Congratulations ! |
This is a draft PR that adds a benchmark of the term merging operation, to make sure I understood what was expected.
I get a result such as below for the baseline:
Close #469