Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove searcher pool #1410

Closed
PSeitz opened this issue Jul 6, 2022 · 0 comments · Fixed by #1411
Closed

Remove searcher pool #1410

PSeitz opened this issue Jul 6, 2022 · 0 comments · Fixed by #1411
Assignees
@PSeitz

Comments

@PSeitz
Copy link
Contributor

PSeitz commented Jul 6, 2022

The searcher pool was originally provided, since searcher methods were mutable. Since there are no mutable methods anymore, we can remove the pool and simply make the searcher cloneable.
@PSeitz PSeitz self-assigned this Jul 6, 2022
PSeitz added a commit that referenced this issue Jul 7, 2022
@PSeitz
remove searcher pool and make Searcher cloneable
e5185b1 
closes #1410
@PSeitz PSeitz mentioned this issue Jul 7, 2022
Merged
PSeitz added a commit that referenced this issue Jul 7, 2022
@PSeitz
remove searcher pool and make Searcher cloneable
fd7086f 
closes #1410
PSeitz added a commit that referenced this issue Jul 7, 2022
@PSeitz
remove searcher pool and make Searcher cloneable
2ade70e 
closes #1410
PSeitz added a commit that referenced this issue Jul 7, 2022
@PSeitz
remove searcher pool and make Searcher cloneable
2e0196c 
closes #1410
PSeitz added a commit that referenced this issue Jul 12, 2022
@PSeitz
remove searcher pool and make Searcher cloneable
8dafb0b 
closes #1410
fulmicoton pushed a commit that referenced this issue Jul 12, 2022
@PSeitz
remove searcher pool and make Searcher cloneable (#1411)
23fe73a 
* remove searcher pool and make Searcher cloneable

closes #1410

* use SearcherInner in InnerIndexReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSeitz PSeitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove searcher pool and make Searcher cloneable quickwit-oss/tantivy
1 participant
@PSeitz