Merge pull request #1476 from quickwit-oss/fix_interpol

add proptest to ff codecs
quickwit-oss · Aug 24, 2022 · 513f682 · 513f682
2 parents c476b53 + 91f2f7e
commit 513f682
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 9 deletions.
diff --git a/fastfield_codecs/Cargo.toml b/fastfield_codecs/Cargo.toml
@@ -17,6 +17,7 @@ rand = {version="0.8.3", optional= true}
 
 [dev-dependencies]
 more-asserts = "0.3.0"
+proptest = "1.0.0"
 rand = "0.8.3"
 
 [features]

diff --git a/fastfield_codecs/src/lib.rs b/fastfield_codecs/src/lib.rs
@@ -124,6 +124,9 @@ impl FastFieldDataAccess for Vec<u64> {
 
 #[cfg(test)]
 mod tests {
+    use proptest::arbitrary::any;
+    use proptest::proptest;
+
     use crate::bitpacked::{BitpackedFastFieldReader, BitpackedFastFieldSerializer};
     use crate::linearinterpol::{LinearInterpolFastFieldReader, LinearInterpolFastFieldSerializer};
     use crate::multilinearinterpol::{
@@ -155,6 +158,24 @@ mod tests {
         }
         (estimation, actual_compression)
     }
+
+    proptest! {
+        #[test]
+        fn test_proptest_small(data in proptest::collection::vec(any::<u64>(), 1..10)) {
+            create_and_validate::<LinearInterpolFastFieldSerializer, LinearInterpolFastFieldReader>(&data, "proptest linearinterpol");
+            create_and_validate::<MultiLinearInterpolFastFieldSerializer, MultiLinearInterpolFastFieldReader>(&data, "proptest multilinearinterpol");
+            create_and_validate::<BitpackedFastFieldSerializer, BitpackedFastFieldReader>(&data, "proptest bitpacked");
+        }
+
+        #[test]
+        fn test_proptest_large(data in proptest::collection::vec(any::<u64>(), 1..6000)) {
+            create_and_validate::<LinearInterpolFastFieldSerializer, LinearInterpolFastFieldReader>(&data, "proptest linearinterpol");
+            create_and_validate::<MultiLinearInterpolFastFieldSerializer, MultiLinearInterpolFastFieldReader>(&data, "proptest multilinearinterpol");
+            create_and_validate::<BitpackedFastFieldSerializer, BitpackedFastFieldReader>(&data, "proptest bitpacked");
+        }
+
+    }
+
     pub fn get_codec_test_data_sets() -> Vec<(Vec<u64>, &'static str)> {
         let mut data_and_names = vec![];
 
@@ -201,15 +222,6 @@ mod tests {
     }
 
     use super::*;
-    pub fn stats_from_vec(data: &[u64]) -> FastFieldStats {
-        let min_value = data.iter().cloned().min().unwrap_or(0);
-        let max_value = data.iter().cloned().max().unwrap_or(0);
-        FastFieldStats {
-            min_value,
-            max_value,
-            num_vals: data.len() as u64,
-        }
-    }
 
     #[test]
     fn estimation_good_interpolation_case() {