add tests for multihop price calcs #1824
Conversation
joe-bowman
requested review from
faddat,
ajansari95 and
arhamchordia
as code owners
WalkthroughThis change introduces a new test case, Changes
Sequence Diagram(s)sequenceDiagram
participant T as Test Suite
participant K as ParticipationRewardsKeeper
participant C as CalcTokenValues Method
T->>K: Unmarshal JSON for pool data (CL and Balancer)
K->>C: Setup pool parameters and data
T->>K: Invoke CalcTokenValues for tokens (aarch, uusdc, uosmo)
K->>T: Return computed token values
T->>T: Assert values match expected results
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)Error: unknown linters: 'usetesting', run 'golangci-lint help linters' to see the list of supported linters ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
x/participationrewards/keeper/distribution_test.go (2)
274-280: Consider using deterministic timestamps in test data.The test data contains future timestamps (e.g., "2024-06-29", "2025-02-14"). While this doesn't affect the test functionality, using deterministic timestamps (e.g., a fixed past date) would make the tests more maintainable and prevent potential confusion.
282-284: Add comments to explain the test scenario.While the function name and inline comments provide some context, it would be helpful to add more detailed comments explaining:
- The purpose of using intermediary pools
- The specific path taken to derive the price (e.g., aarch → usdc → osmo)
- Why this test case is important
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
x/participationrewards/keeper/distribution_test.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: test quicksilver (darwin, arm64)
- GitHub Check: build quicksilver (darwin, arm64)
- GitHub Check: test quicksilver (amd64, windows)
- GitHub Check: build quicksilver (amd64, darwin)
- GitHub Check: test quicksilver (amd64, linux)
- GitHub Check: build quicksilver (amd64, windows)
- GitHub Check: build quicksilver (amd64, linux)
- GitHub Check: lint
- GitHub Check: Analyze
🔇 Additional comments (1)
x/participationrewards/keeper/distribution_test.go (1)
282-337: LGTM! Well-structured test implementation.The test function is well-implemented with:
- Clear setup of test environment
- Proper error handling
- Good test data organization
- Appropriate assertions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
=======================================
Coverage 63.07% 63.07%
=======================================
Files 172 172
Lines 15549 15549
=======================================
Hits 9807 9807
Misses 4933 4933
Partials 809 809
Flags with carried forward coverage won't be shown. Click here to find out more. |
1. Summary
Add additional tests for checking MultiHop price determination.
Summary by CodeRabbit