Add claimsmanager udpate spec. #1788
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
x/claimsmanager/spec/README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### MsgDeleteClaimableEvent |
There was a problem hiding this comment.
Do we require this?
I think just having a method on the Keeper to do this is sufficient. It should be called by whichever module created the event in the first place. Should not require a tx to remove anything.
There was a problem hiding this comment.
Makes sense. I will remove it then.
My idea about the design is to be controlled by contracts as well.
There was a problem hiding this comment.
That is a fair point. I’m not terribly familiar with how bindings between cw and go logic work.
There was a problem hiding this comment.
Contracts need proto messages that they can call.
While writing rust contracts we need a QuickSilver proto lib that gives rust code for calling those endpoints.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
=======================================
Coverage 61.38% 61.38%
=======================================
Files 196 196
Lines 17228 17228
=======================================
Hits 10575 10575
Misses 5783 5783
Partials 870 870
Flags with carried forward coverage won't be shown. Click here to find out more. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
…one/quicksilver into spec/claimsmanager
| // MsgSubmitClaimResponse defines the MsgSubmitClaim response type. | ||
| message MsgSubmitClaimResponse {} | ||
|
|
||
| message MsgSubmitClaimableEventClaim { |
There was a problem hiding this comment.
This is not needed. Will get rid of it later.
…one/quicksilver into spec/claimsmanager
| for k := range m.Heights { | ||
| v := m.Heights[k] | ||
| baseI := i | ||
| i = encodeVarintClaimsmanager(dAtA, i, uint64(v)) | ||
| i-- | ||
| dAtA[i] = 0x10 | ||
| i -= len(k) | ||
| copy(dAtA[i:], k) | ||
| i = encodeVarintClaimsmanager(dAtA, i, uint64(len(k))) | ||
| i-- | ||
| dAtA[i] = 0xa | ||
| i = encodeVarintClaimsmanager(dAtA, i, uint64(baseI-i)) | ||
| i-- | ||
| dAtA[i] = 0x1a | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for k, v := range m.Heights { | ||
| _ = k | ||
| _ = v | ||
| mapEntrySize := 1 + len(k) + sovClaimsmanager(uint64(len(k))) + 1 + sovClaimsmanager(uint64(v)) | ||
| n += mapEntrySize + 1 + sovClaimsmanager(uint64(mapEntrySize)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
No description provided.