Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility of JS_HasException without JS_EXTERN is hidden by default (CMakeLists.txt) #785

Closed
laishere opened this issue Jan 4, 2025 · 3 comments
Closed

Visibility of JS_HasException without JS_EXTERN is hidden by default (CMakeLists.txt) #785

laishere opened this issue Jan 4, 2025 · 3 comments

Comments

@laishere
Copy link
Contributor

laishere commented Jan 4, 2025

quickjs/quickjs.h

Line 617 in 9fc7940

JS_BOOL JS_HasException(JSContext *ctx);

quickjs/CMakeLists.txt

Line 8 in 9fc7940

set(CMAKE_C_VISIBILITY_PRESET hidden)

I wonder if this is by mistake or for some purpose?
@saghul
Copy link
Contributor

saghul commented Jan 4, 2025

Ops, that's an oversight! Would you like to send a PR?

@laishere
Copy link
Contributor Author

laishere commented Jan 5, 2025

No problem!

saghul pushed a commit that referenced this issue Jan 5, 2025
@laishere @saghul
Expose JS_HasException API (#785)
b675a95
@saghul
Copy link
Contributor

saghul commented Jan 5, 2025

Merged!

@saghul saghul closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saghul @laishere