-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Only do cron job on main repository #46
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -8,6 +8,7 @@ on: | |||
|
|||
jobs: | |||
compile: | |||
if: github.repository == 'quic-yocto/meta-qcom-hwe' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we should have the same logic applied on all jobs, not only nightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in force push
66cf78b
to
6eb5c68
Compare
6eb5c68
to
c389291
Compare
Needs rebase. |
I noticed my doanac/meta-qcom-hwe fork was trying to workflows it doesn't have access to since we use self-hosted runners. Signed-off-by: Andy Doan <andy@foundries.io>
c389291
to
09ec125
Compare
rebased on latest main |
@@ -9,6 +9,7 @@ on: | |||
|
|||
jobs: | |||
repolinter: | |||
if: github.repository == 'quic-yocto/meta-qcom-hwe' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to leave the jobs which run on github runners, and only limit the ones that run on self hosted runners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine either way. I got the impression Ricardo was leaning towards this approach
I noticed my doanac/meta-qcom-hwe fork was trying to run this cron job every night but fails because there is no runner for it.