Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only do cron job on main repository #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

doanac
Copy link
Contributor

@doanac doanac commented Oct 16, 2024

I noticed my doanac/meta-qcom-hwe fork was trying to run this cron job every night but fails because there is no runner for it.

Copy link
Contributor

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8,6 +8,7 @@ on:

jobs:
compile:
if: github.repository == 'quic-yocto/meta-qcom-hwe'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should have the same logic applied on all jobs, not only nightly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in force push

@ricardosalveti
Copy link
Contributor

Needs rebase.

I noticed my doanac/meta-qcom-hwe fork was trying to workflows it
doesn't have access to since we use self-hosted runners.

Signed-off-by: Andy Doan <andy@foundries.io>
@doanac
Copy link
Contributor Author

doanac commented Oct 20, 2024

rebased on latest main

@@ -9,6 +9,7 @@ on:

jobs:
repolinter:
if: github.repository == 'quic-yocto/meta-qcom-hwe'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to leave the jobs which run on github runners, and only limit the ones that run on self hosted runners?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way. I got the impression Ricardo was leaning towards this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants