only start PMTUD after handshake confirmation #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 131 131
Lines 9650 9650
=======================================
Hits 8248 8248
Misses 1034 1034
Partials 368 368
Continue to review full report at Codecov.
|
Our PMTUD packets are never coalesced packets. Since we try packing coalesced packets until the handshake is confirmed, it makes sense to start PMTUD then.
marten-seemann
force-pushed
the
pmtud-after-handshake-confirmation
branch
from
142cd08
to
43d5fde
Compare
Closed
lucas-clemente
approved these changes
Apr 2, 2021
|
This was unmerged due to the mess in #3102. Will replace with a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PMTUD packets are never coalesced packets. Since we try packing coalesced packets until the handshake is confirmed, it makes sense to start PMTUD then.
This mismatch in expectation can also lead to busy-looping: we might set a timer to send a PMTUD packet, but then we never send one, because the handshake isn't confirmed yet.