Merge pull request #39 from questionlp/develop

Fix issue where scores are returned as int rather than Decimal for panelist/scores
questionlp · Aug 30, 2023 · b4f0fba · b4f0fba
2 parents 462951e + 73d8008
commit b4f0fba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changes
 
+## 2.3.2
+
+### Application Changes
+
+- Fix issue where `panelists/scores/id` and `panelists/scores/slug` return scores as `int` instead of `Decimal` due to `Union[int, Decimal]` would return an `int`. Switched to `Union[Decimal, int]` to allow `Decimal` to take precedence
+
 ## 2.3.1
 
 ### Component Changes

diff --git a/app/config.py b/app/config.py
@@ -9,7 +9,7 @@
 from typing import Any, Dict
 
 API_VERSION = "2.0"
-APP_VERSION = "2.3.1"
+APP_VERSION = "2.3.2"
 
 
 def load_config(

diff --git a/app/models/panelists.py b/app/models/panelists.py
@@ -6,7 +6,7 @@
 """Panelists Models"""
 
 from decimal import Decimal
-from typing import List, Optional, Tuple
+from typing import List, Optional, Tuple, Union
 from pydantic import BaseModel, conint, Field
 
 
@@ -193,7 +193,7 @@ class PanelistScoresList(BaseModel):
     shows: Optional[List[str]] = Field(
         default=None, title="List of Panelist Appearances as Show Dates"
     )
-    scores: Optional[List[int]] = Field(default=None, title="List of Panelist Scores")
+    scores: Optional[List[Union[Decimal, int]]] = Field(default=None, title="List of Panelist Scores")
 
 
 class ScoresOrderedPair(BaseModel):