Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration option #4

Closed
raae opened this issue Nov 13, 2021 · 3 comments · Fixed by #16
Closed

Add duration option #4

raae opened this issue Nov 13, 2021 · 3 comments · Fixed by #16
Assignees
@olavea
Labels
claimed Someone is working on it good first issue Good for newcomers released

Comments

@raae
Copy link
Member

raae commented Nov 13, 2021 •
edited
Loading

Make it possible to tweak the time before the snow ends. It is now hardcoded to 15s.
@raae raae added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 15, 2021
@raae
Copy link
Member Author

raae commented Nov 21, 2021

This is a good one for you @olavea.
Add a duration option to the options.
Then use that duration instead of 15s in the code.

@raae raae changed the title Add timefame option Add duration option Nov 21, 2021
olavea added a commit to olavea/gatsby-plugin-let-it-snow that referenced this issue Nov 23, 2021
@olavea
fix: started on Add duration option queen-raae#4
921d103
@raae raae added the claimed Someone is working on it label Nov 23, 2021
@raae raae changed the title Add duration option n Nov 23, 2021
@raae raae changed the title n Add duration option Nov 23, 2021
@raae
Copy link
Member Author

raae commented Nov 25, 2021

Documentation on how to require a number with Joi: https://joi.dev/api/?v=17.4.2#number
It should also probably be required to be larger than 5s: https://joi.dev/api/?v=17.4.2
It should probably also be required to be an integer: https://joi.dev/api/?v=17.4.2#numberinteger

@raae raae linked a pull request Nov 25, 2021 that will close this issue
fix: started on Add duration option #4 #16
Merged
@raae raae removed the help wanted Extra attention is needed label Nov 25, 2021
@raae raae changed the title Add duration option c Nov 26, 2021
@raae raae changed the title c Add duration option Nov 26, 2021
@raae raae closed this as completed in #16 Dec 3, 2021
raae added a commit that referenced this issue Dec 3, 2021
@olavea @raae
feat: add duration option, closes #4 (#16)
e9478fa 
Co-authored-by: Benedicte Raae <raae@raae.codes>
raae-bot pushed a commit that referenced this issue Dec 3, 2021
@semantic-release-bot
chore(release): 0.5.0 [skip ci]
ddd74dd 
# [0.5.0](v0.4.1...v0.5.0) (2021-12-03)

### Features

* add duration option, closes [#4](#4) ([#16](#16)) ([e9478fa](e9478fa))
@raae-bot
Copy link

raae-bot commented Dec 3, 2021

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavea olavea

Labels
claimed Someone is working on it good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: started on Add duration option #4 queen-raae/gatsby-plugin-let-it-snow
3 participants
@raae @olavea @raae-bot