-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some undefined terms #705
base: main
Are you sure you want to change the base?
Conversation
These changes all seem reasonable. I will wait until my QUDT colleagues have a chance to weigh in though. Also, be aware that we are currently discussing the modeling of datatypes in SHACL, which raises a number of issues, so things may be changing. But (in my opinion), it's good to clean house with what we have anyway. |
We finally got a chance to discuss this and we're fine with your suggestions except for changing the prefix qudt.type to qudt. This is because we generally use qudt: as a prefix for schema entities (classes, properties...) and other prefixes for the vocabulary/instances (e.g. unit:, quantitykind:, constant:). After some back and forth, we settled on qudt_type: as the preferred prefix name rather than qudt.type or just qudt. If you make that change, I think we're good. |
Here's my attempt at resolving a first portion of #704. It might be easier to review the individual commits than the whole pull request. Please let me know if I'm on the right track 😊