Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor pretrainedmodels #1039

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

adamjstewart
Copy link
Collaborator

Same as #1036

Pretrainedmodels doesn't have wheels on PyPI, and is no longer maintained. It contains numerous Python version compatibility issues as well. Let's vendor it and maintain it ourselves. This will make SMP easier to install.

We can and should try to deprecate these in favor of timm in the long run. This PR doesn't do that though.

@adamjstewart adamjstewart force-pushed the deps/pretrainedmodels branch from 6c68ae4 to 18921b2 Compare January 25, 2025 11:47
@adamjstewart adamjstewart requested a review from qubvel January 26, 2025 15:04
Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving encoders! I think we can cleat the code a bit, removing unnecessary methods, functions, vars (same as for the efficientnet). It will also make the patch more test covered 😄

segmentation_models_pytorch/encoders/_inceptionresnetv2.py Outdated Show resolved Hide resolved
segmentation_models_pytorch/encoders/_inceptionv4.py Outdated Show resolved Hide resolved
segmentation_models_pytorch/encoders/_inceptionv4.py Outdated Show resolved Hide resolved
segmentation_models_pytorch/encoders/_dpn.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamjstewart adamjstewart merged commit eb17637 into qubvel-org:main Jan 30, 2025
17 checks passed
@adamjstewart adamjstewart deleted the deps/pretrainedmodels branch January 30, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants