-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor pretrainedmodels #1039
Vendor pretrainedmodels #1039
Conversation
6c68ae4
to
18921b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving encoders! I think we can cleat the code a bit, removing unnecessary methods, functions, vars (same as for the efficientnet). It will also make the patch more test covered 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Same as #1036
Pretrainedmodels doesn't have wheels on PyPI, and is no longer maintained. It contains numerous Python version compatibility issues as well. Let's vendor it and maintain it ourselves. This will make SMP easier to install.
We can and should try to deprecate these in favor of timm in the long run. This PR doesn't do that though.