Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new:dev:SDK-387:Add hive version support #303

Merged
merged 32 commits into from
Apr 1, 2020

Conversation

satyabolnedi
Copy link
Contributor

No description provided.

Copy link
Contributor

@tarrygo tarrygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write test case for it

self.set_hadoop_settings(custom_hadoop_config, use_qubole_placement_policy,
is_ha, fairscheduler_config_xml,
default_pool, enable_rubix)
self.set_hive_settings(hive_version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify the value of hive_version column in hive_cluster_configs with and without this change.

Copy link
Contributor Author

@satyabolnedi satyabolnedi Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarrygo verified from DB with the updated sdk changes and hive version being updated with 3.1

@chattarajoy chattarajoy force-pushed the unreleased branch 2 times, most recently from 8a95947 to caec9b1 Compare March 2, 2020 13:09
Copy link
Contributor

@tarrygo tarrygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@chattarajoy chattarajoy merged commit 8a99f5d into qubole:unreleased Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants