SDK-383: Add Retries to all Get requests in case of 500 Response #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunasra
approved these changes
Dec 8, 2019
| def get_raw(self, path, params=None): | ||
| return self._api_call_raw("GET", path, params=params) | ||
|
|
||
| @retry((RetryWithDelay, requests.Timeout), tries=6, delay=30, backoff=2) | ||
| @retry((RetryWithDelay, requests.Timeout, ServerError), tries=6, delay=30, backoff=2) |
There was a problem hiding this comment.
This will apply to all network call? @chattarajoy
There was a problem hiding this comment.
only get requests. Retrying put/post/delete requests might case issues, hence added these to get requests only.
chattarajoy
changed the title
sunasra
pushed a commit
that referenced
this pull request
Dec 11, 2019
(cherry picked from commit 99544a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often see cases when Airflow Jobs fail because the polling API returns a 500 Response. This change adds retries to all get calls when a 500 Response is returned as a result of heavy load on Qubole's Webapp.