-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csv: rename deployment (PROJQUAY-3239) #56
csv: rename deployment (PROJQUAY-3239) #56
Conversation
/cherrypick redhat-3.6 |
@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of redhat-3.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HammerMeetNail, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
On v3.6.3 the selectors have changed. Selectors are, according to OLM, an immutable field therefore we need to rename the deployment. By renaming the deployment OLM will delete the previous deployment and create a new one: operator-framework/operator-lifecycle-manager#952 (comment)
@ricardomaraschini: new pull request created: #57 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick redhat-3.7 |
@ricardomaraschini: new pull request created: #58 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On v3.6.3 the selectors have changed. Selectors are, according to OLM,
an immutable field therefore we need to rename the deployment.
By renaming the deployment OLM will delete the previous deployment and
create a new one:
operator-framework/operator-lifecycle-manager#952 (comment)