Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv: rename deployment (PROJQUAY-3239) #56

Merged
merged 1 commit into from
Feb 16, 2022
Merged

csv: rename deployment (PROJQUAY-3239) #56

merged 1 commit into from
Feb 16, 2022

Conversation

ricardomaraschini
Copy link
Contributor

On v3.6.3 the selectors have changed. Selectors are, according to OLM,
an immutable field therefore we need to rename the deployment.

By renaming the deployment OLM will delete the previous deployment and
create a new one:

operator-framework/operator-lifecycle-manager#952 (comment)

@ricardomaraschini
Copy link
Contributor Author

/cherrypick redhat-3.6

@openshift-cherrypick-robot
Copy link
Collaborator

@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of redhat-3.6 in a new PR and assign it to you.

In response to this:

/cherrypick redhat-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HammerMeetNail, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini
Copy link
Contributor Author

/retest

On v3.6.3 the selectors have changed. Selectors are, according to OLM,
an immutable field therefore we need to rename the deployment.

By renaming the deployment OLM will delete the previous deployment and
create a new one:

operator-framework/operator-lifecycle-manager#952 (comment)
@openshift-cherrypick-robot
Copy link
Collaborator

@ricardomaraschini: new pull request created: #57

In response to this:

/cherrypick redhat-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor Author

/cherrypick redhat-3.7

@openshift-cherrypick-robot
Copy link
Collaborator

@ricardomaraschini: new pull request created: #58

In response to this:

/cherrypick redhat-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants