Avoid special symbols in passwords #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some special characters may cause issues in DB URI unless they are
properly escaped. For example, the password "ab/cd" cannot be used
directly in the URI
postgresql://user:ab/cd@localhost/quay
because netloc became "user:ab", while we want it to be
"user:ab/cd@localhost".
dmage
added
the
ok-to-test
BadgerOps
reviewed
Apr 18, 2024
| @@ -2,5 +2,5 @@ | |||
| set_fact: | |||
| secret_key: "{{ lookup('community.general.random_string', length=48, base64=True) }}" | |||
| database_secret_key: "{{ lookup('community.general.random_string', length=48, base64=True) }}" | |||
| pgdb_password: "{{ lookup('community.general.random_string', length=24, base64=True) }}" | |||
There was a problem hiding this comment.
ah, I went with base64 thinking [a-z[A-Z][0-9] would be safe enough for this automation and forgot about the couple special characters it allows.
dmage
added
ok-to-test
|
@harishsurf @jonathankingfc can you approve it? it'll fix intermittent issues during installation and reduce unnecessary support requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some special characters may cause issues in DB URI unless they are properly escaped. For example, the password "ab/cd" cannot be used directly in the URI
because netloc became "user:ab", while we want it to be "user:ab/cd@localhost".