periodic: account for differences with Konflux built images #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1444 |
RTann
reviewed
Nov 26, 2024
Comment on lines
+53
to
+56
| case rpm.SourceNEVRA != "": | ||
| source = rpm.SourceNEVRA | ||
| case rpm.SourceName != "": | ||
| source = rpm.SourceName |
There was a problem hiding this comment.
is it possible for both to be populated?
There was a problem hiding this comment.
Yes, older manifests will have SourceNEVRA populated, newer ones won't but they have the same information in SourceName.
crozzy
force-pushed
the
update-periodic-rpm-test
branch
from
fada256 to
b937e04
Compare
For the RPM test we check the index report against the pyxis manifest for that image. The format of this manifest has recently changed when they started producing builds from Konflux, this change accounts for those changes. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
update-periodic-rpm-test
branch
from
b937e04 to
ae50b58
Compare
RTann
approved these changes
Nov 26, 2024
Comment on lines
+53
to
+56
| case rpm.SourceNEVRA != "": | ||
| source = rpm.SourceNEVRA | ||
| case rpm.SourceName != "": | ||
| source = rpm.SourceName |
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the RPM test we check the index report against the pyxis manifest for that image. The format of this manifest has recently changed when they started producing builds from Konflux, this change accounts for those changes.