Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with @quasar/app-vite 2.0.0-rc.2 due to declare module '@vue/runtime-core' #402

Closed
maiolica opened this issue Nov 20, 2024 · 1 comment

Comments

@maiolica
Copy link

Describe the bug
The file dist/types/index.d.ts contains this declaration:

declare module '@vue/runtime-core' {
    interface ComponentCustomProperties {
    }
}

which breaks the types (see quasarframework/quasar#17416).

It should be changed to:

declare module 'vue' {
    interface ComponentCustomProperties {
    }
}

To Reproduce
Steps to reproduce the behavior:

  1. Install the latest version of @quasar/app-vite
  2. Install the next version of quasar-ui-qmarkdown
  3. Import the QMarkdown component
  4. Observe the types errors in the IDE

Expected behavior
No types error

Environment

Operating System - Darwin(24.1.0) - darwin/arm64
NodeJs - 22.9.0

Global packages
  NPM - Not installed
  yarn - 1.22.22
  pnpm - Not installed
  bun - Not installed
  @quasar/cli - 2.4.1
  @quasar/icongenie - Not installed
  cordova - Not installed

Important local packages
  quasar - 2.17.4 -- Build high-performance VueJS user interfaces (SPA, PWA, SSR, Mobile and Desktop) in record time
  @quasar/app-vite - 2.0.0-rc.2 -- Quasar Framework App CLI with Vite
  @quasar/extras - 1.16.13 -- Quasar Framework fonts, icons and animations
  eslint-plugin-quasar - Not installed
  vue - 3.5.13 -- The progressive JavaScript framework for building modern web UI.
  vue-router - 4.4.5
  pinia - 2.2.6 -- Intuitive, type safe and flexible Store for Vue
  vuex - Not installed
  vite - 5.4.11 -- Native-ESM powered web dev build tool
  vite-plugin-checker - Not installed
  eslint - 8.57.1 -- An AST-based pattern checker for JavaScript.
  esbuild - 0.24.0 -- An extremely fast JavaScript and CSS bundler and minifier.
  typescript - 5.6.3 -- TypeScript is a language for application scale JavaScript development
@maiolica maiolica changed the title Incompatibility with @quasar/app-vite 2.0.0-rc.2 due to declare module '@vue/runtime-core Incompatibility with @quasar/app-vite 2.0.0-rc.2 due to declare module '@vue/runtime-core' Nov 20, 2024
hawkeye64 added a commit to hawkeye64/quasar-json-api that referenced this issue Dec 18, 2024
@hawkeye64
Copy link
Member

Hopefully, this will be resolved in the upcoming version of v2.0.1. If not, you can reopen this ticket.

hawkeye64 added a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants