Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/9816 #9827

Merged
merged 4 commits into from
May 31, 2024
Merged

Bugfix/9816 #9827

merged 4 commits into from
May 31, 2024

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented May 31, 2024

Closes #9816.

This will fail CI because pdftotext isn't installed, so that needs fixing.

@cscheid cscheid requested a review from cderv May 31, 2024 18:20
@cderv
Copy link
Collaborator

cderv commented May 31, 2024

Nice idea!

Is this expected that the test passes on windows though ?
https://github.com/quarto-dev/quarto-cli/actions/runs/9322596818/job/25664024228?pr=9827#step:27:987

I thought it would need the deps. I know how to install it, but I am surprised it worked already

@cscheid
Copy link
Collaborator Author

cscheid commented May 31, 2024

I'm surprised too! I read somewhere that pdftotext is installed with miktex; I wonder if tinytex also installs it?

@cderv
Copy link
Collaborator

cderv commented May 31, 2024

Oh lets me check that ! highly possible !

@cderv
Copy link
Collaborator

cderv commented May 31, 2024

So locally I need to install it at least. Otherwise,

Failed to spawn 'pdftotext': program not found

But when I do have, it works ok.

So it seems that somehow, pdftotext is on PATH in our CI. I will to know what brings it, so that we are not surprised when it breaks, but for now this is good news.

@cderv
Copy link
Collaborator

cderv commented May 31, 2024

I have got the answer !

It is available with Git For Windows as part of mingw64 distribution

> gcm pdftotext

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     pdftotext.exe                                      0.0.0.0    C:\Program Files\Git\mingw64\bin\pdftotext.exe

So it is found !

Though version available is 4.00

> pdftotext --version
pdftotext version 4.00
Copyright 1996-2017 Glyph & Cog, LLC

But as long as it works ok ! I think we should be good.

If you prefer to be safe, installing as I mentioned in other thread will be the way to go. Just tells me

@cscheid
Copy link
Collaborator Author

cscheid commented May 31, 2024

This is good enough for me!

@cscheid cscheid merged commit b4b53cf into main May 31, 2024
48 of 49 checks passed
@cscheid cscheid deleted the bugfix/9816 branch May 31, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typst callouts are bracketed
2 participants