Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typst callout without body #9772

Merged
merged 2 commits into from
May 31, 2024

Conversation

debdagybra
Copy link
Contributor

See #9763

@cderv cderv requested a review from cscheid May 27, 2024 09:26
@cderv cderv linked an issue May 27, 2024 that may be closed by this pull request
@cscheid
Copy link
Collaborator

cscheid commented May 30, 2024

Thanks for the PR. Before we can merge, we need you to sign and submit a CLA: https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md

I also would like to understand how this works across formats. I believe it works for HTML, but it might have been by accident.

We'd like to at least test:

  • html
  • revealjs
  • pdf
  • typst
  • docx

@debdagybra
Copy link
Contributor Author

Before we can merge, we need you to sign and submit a CLA: https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md

Done :)

You were right, the behaviour isn't consistent in all formats

Currently, when the body of the callout is empty:

  • html and revealjs don't show the body part
  • pdf (tinytex), typst and docx show an empty body part.

@cderv
Copy link
Collaborator

cderv commented May 31, 2024

Interestingly, same report on revealjs

@cscheid
Copy link
Collaborator

cscheid commented May 31, 2024

I'm going to merge this one and start a new issue for tracking all different cases in callouts.

@cscheid cscheid merged commit e156acb into quarto-dev:main May 31, 2024
49 checks passed
@cscheid
Copy link
Collaborator

cscheid commented May 31, 2024

Thanks for the PR, @debdagybra!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typst callout without body
3 participants