feature matrix - fix path handling for windows and linux support #9063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it does not work for me if I try to render the feature matrix on windows.
I suggest we use
pathlib
to handle file path instead of usingsplit()
and some separator which would require to handle each case.pathlib is from python 3.4 BTW https://docs.python.org/3/library/pathlib.html
I am opening this PR so that you can check this is working for you.
@gordonwoodhull I can make a PR or a commit to your branch. Otherwise here is a patch