Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: QR shortcodes #9021

Closed
wants to merge 6 commits into from
Closed

Feature: QR shortcodes #9021

wants to merge 6 commits into from

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Mar 10, 2024

TODO

  • Figure out why data URIs don't work well on PDF format
  • support usage in metadata

Minimal example

---
title: qr code test
format: revealjs
---

## Neat!

See source for this PR:

{{< qr https://github.com/quarto-dev/quarto-cli/pull/9021 width=200px height=200px >}}
image

@cscheid
Copy link
Collaborator Author

cscheid commented Mar 11, 2024

Figure out why data URIs don't work well on PDF format

This is a separate bug that's easy to fix in its own PR.

support usage in metadata

I think I want to fix this in its own PR as well. Right now, no TypeScript shortcode works in metadata.

Ideally we would be resolving this shortcode in Lua instead of TypeScript. The problem is that there's no easy-to-use QR code library in Lua, and there's one in TypeScript.

@cscheid
Copy link
Collaborator Author

cscheid commented Mar 15, 2024

I'm going to close this because before we fix our deno bundling, this feature won't work;

  • We can't use the skypack version of qrcode in deno because it's confused about browser vs server setting and expects the canvas API to exist
  • We can't use the npm version of qrcode in Quarto because deno doesn't support deno bundle with NPM imports.

@cscheid cscheid closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant