-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: typst fig align code cell #8991
Conversation
Great! It looks like some of the tests are failing because of different whitespace handling on windows? |
Interesting.. I'll see if |
Yep, it also works for tables #8797 if I broaden the selector: - local cod = quarto.utils.match(".cell/[1]/.cell-output-display")(div)
+ local cod = quarto.utils.match(".cell/:child/.cell-output-display")(div) But it's confusing to have an expected alignment for tables but no way to control table alignment (as discussed there), so I'm not sure if that's a good enough solution. |
For the newline, I see we are using also quarto-cli/tests/docs/smoke-all/2023/01/26/asciidoc-callout.qmd Lines 5 to 11 in 248a3a4
I found that to cover what I found on the web
|
dc1ad66
to
0cba339
Compare
Thanks @cderv, that’s the universal newline and most precise. |
Superceded by #9052 |
Thanks for closing. Can we delete the branch just asking for keep branch numbers in remotes cleaned |
Thanks @cderv, deleted this and a bunch of other temporary branches I had. |
@cscheid, here is a proposed solution for Typst
fig-align
(#8767) for discussion at our meeting today.It simply marks
.cell > .cell-output-display
as.quarto-scaffold
, maybe too broad:fig-align
should be applied to all. (I'll check that as well.)Note we can't directly test if alignment is working, we can only test if extra blocks surround the
#align()
.Another possible fix can be made in post-processing, messier but more focused. See alternate branch here:
https://github.com/quarto-dev/quarto-cli/compare/fix/typst-fig-align-code-cell-in-post?expand=1