WIP: typst fig align code cell

[gordonwoodhull]

@cscheid, here is a proposed solution for Typst fig-align (#8767) for discussion at our meeting today.

It simply marks .cell > .cell-output-display as .quarto-scaffold, maybe too broad:

• There's a good chance this will "accidentally" fix Centered tables from code using typst #8797, will test now
• What happens if there are multiple plot outputs? Existing code skips that case but I think expectation is that fig-align should be applied to all. (I'll check that as well.)

Note we can't directly test if alignment is working, we can only test if extra blocks surround the #align().

Another possible fix can be made in post-processing, messier but more focused. See alternate branch here:
https://github.com/quarto-dev/quarto-cli/compare/fix/typst-fig-align-code-cell-in-post?expand=1

[cscheid]

Great! It looks like some of the tests are failing because of different whitespace handling on windows?

[gordonwoodhull]

Interesting.. I'll see if \s* works instead of \n

[gordonwoodhull]

Yep, it also works for tables #8797 if I broaden the selector:

-            local cod = quarto.utils.match(".cell/[1]/.cell-output-display")(div)
+            local cod = quarto.utils.match(".cell/:child/.cell-output-display")(div)

But it's confusing to have an expected alignment for tables but no way to control table alignment (as discussed there), so I'm not sure if that's a good enough solution.

[cderv]

For the newline, I see we are using also (\r\n?|\n) (3452940)

quarto-cli/tests/docs/smoke-all/2023/01/26/asciidoc-callout.qmd

Lines 5 to 11 in 248a3a4

	_quarto:
	tests:
	asciidoc:
	ensureFileRegexMatches:
	-
	- '\[NOTE\](\r\n?|\n).Bruv(\r\n?|\n)===='
	- '\[TIP\](\r\n?|\n)===='

I found that to cover what I found on the web

Linux uses \n for a new-line, Windows \r\n and old Macs \r

\s is spaces, tabs and new lines so it works also. More broad though as it covers spaces and tabs.

[gordonwoodhull]

Thanks @cderv, that’s the universal newline and most precise.

[gordonwoodhull]

Superceded by #9052

[cderv]

Thanks for closing. Can we delete the branch fix/typst-fig-align-code-cell in the repo then ?

just asking for keep branch numbers in remotes cleaned

[gordonwoodhull]

Thanks @cderv, deleted this and a bunch of other temporary branches I had.