Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create _language-ca.yml #6287

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Create _language-ca.yml #6287

merged 2 commits into from
Jul 21, 2023

Conversation

encosllo
Copy link
Contributor

Catalan language

Catalan language
@cscheid
Copy link
Collaborator

cscheid commented Jul 20, 2023

Thank you for this contribution! Can you confirm you've sent us a collaborator agreement?

@cscheid
Copy link
Collaborator

cscheid commented Jul 20, 2023

Hm. I now realize we have an open PR with this contribution from a separate user, #5968.

@cscheid
Copy link
Collaborator

cscheid commented Jul 20, 2023

@encosllo I manually merged the two translations, and I generally took the earlier contribution over yours (but there's some you've added, so I kept them here!) If you can confirm you're ok with the changes and the collaborator agreement, I'll be happy to merge. Thanks again!

@encosllo
Copy link
Contributor Author

@cscheid Thanks for merging the translations. I'm happy with it. The collaborator agreement has been already sent. Thanks!

@cscheid cscheid merged commit f5dbdb4 into quarto-dev:main Jul 21, 2023
7 checks passed
@jmaspons
Copy link
Contributor

Hi! I'm the one from the first PR for the Catalan translation. It seems that some strings have been lost in the merge (e.g. section-title-abstract: "Resum" https://github.com/quarto-dev/quarto-cli/blob/main/src/resources/language/_language-ca.yml)

@jmaspons
Copy link
Contributor

jmaspons commented Aug 5, 2023

Hi! I'm the one from the first PR for the Catalan translation. It seems that some strings have been lost in the merge (e.g. section-title-abstract: "Resum" https://github.com/quarto-dev/quarto-cli/blob/main/src/resources/language/_language-ca.yml)

ping @encosllo @cscheid

@cscheid
Copy link
Collaborator

cscheid commented Aug 11, 2023

@jmaspons Thanks for catching that. I've restored those in the latest commit; a new release should be out shortly after.

@jmaspons
Copy link
Contributor

Still some missing translations. I created a new PR #6531 @cscheid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants