Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email extension for Quarto #6181

Merged
merged 37 commits into from
Oct 19, 2023
Merged

Email extension for Quarto #6181

merged 37 commits into from
Oct 19, 2023

Conversation

rich-iannone
Copy link
Collaborator

@rich-iannone rich-iannone commented Jul 11, 2023

This contains the extension email, which is a filter that can use an .email-classed div as content for an HTML email through Posit Connect (via rsconnect for R/Python).

Fixes: #4946

@rich-iannone rich-iannone marked this pull request as ready for review August 21, 2023 20:15
Copy link
Collaborator

@dragonstyle dragonstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great- I made two very minor comments that I think you should take a quick look at (more hygiene than real changes).

src/resources/filters/quarto-post/email.lua Outdated Show resolved Hide resolved
@rich-iannone
Copy link
Collaborator Author

rich-iannone commented Oct 19, 2023

Seems like there's another issue that cropped up. In the integrated extension, the div with the .email class isn't omitted from the main report file. Also, the preview .html file doesn't get written. I'll take a look into this.

We are good! Turns out I was re-testing html instead of email in a manual testing .qmd file. Tests with email work perfectly.

@dragonstyle dragonstyle merged commit dd60f8c into main Oct 19, 2023
47 checks passed
@dragonstyle dragonstyle deleted the feature/email-extension branch October 19, 2023 20:06
@cscheid
Copy link
Collaborator

cscheid commented Oct 19, 2023

This is huge! 🎉

@cderv
Copy link
Collaborator

cderv commented Oct 19, 2023

Awesome work @rich-iannone ! Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email Integration
4 participants