Adapt checking knitr capabilities to .Rprofile that would cat() some value
#6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e values. This would make `stdout` contain other lines that our expected JSON. To prevent that we wrap our JSON stdout into specific lines, that allows us to unwrap.
|
This approach LGTM! You may want to call the delimiter |
|
Oh indeed. I completely mix it up. I'll change and merge. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #6154
The case is a user
.Rprofilethat would contain somecat()call. This would add some lines instdout, but we currently expect all thestdoutto be our JSON string.This makes the JSON parsing fails and R reported as not found (while
quarto renderworks ok)This PR adds special string content that we can match easily to unwrap the JSON content from stdout to check the capabilities.
@jjallaire adding you as review to check this is ok to do that. I believe this is without side effect.