Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/giscus-dark-toggle #5020

Merged
merged 21 commits into from
May 3, 2023
Merged

bug/giscus-dark-toggle #5020

merged 21 commits into from
May 3, 2023

Conversation

allenmanning
Copy link
Contributor

#closes #4820

@allenmanning allenmanning added this to the v1.4 milestone Mar 29, 2023
@allenmanning allenmanning self-assigned this Mar 29, 2023
allenmanning
allenmanning commented Mar 29, 2023
View reviewed changes
src/core/giscus.ts Outdated Show resolved Hide resolved
rich-iannone
rich-iannone approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and the included tests cover the changes made. Minor nit (take it or leave it) is to include a space after using if (in two instances).

@allenmanning allenmanning marked this pull request as draft April 18, 2023 12:19
@allenmanning allenmanning changed the title Bug/giscus dark toggle bug/giscus-dark-toggle Apr 26, 2023
@allenmanning allenmanning marked this pull request as ready for review April 27, 2023 07:30
dragonstyle
dragonstyle reviewed Apr 27, 2023
View reviewed changes
src/core/giscus.ts Outdated Show resolved Hide resolved
@dragonstyle
Copy link
Collaborator

One tiny lint and otherwise looks great! Nice improvement to theming!

@allenmanning allenmanning merged commit 4a4e9f1 into main May 3, 2023
@allenmanning allenmanning deleted the bug/giscus-dark-toggle branch May 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonstyle dragonstyle dragonstyle approved these changes

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees

@allenmanning allenmanning

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

When using a dark theme, giscus should use a dark theme as well.
3 participants
@allenmanning @dragonstyle @rich-iannone