Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more information to the error when the chrome process has errored #2499

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Sep 19, 2022

It will allow us to get more information in bug report like in #1822

It does not solve our chromium install issue though, but first step to understand what the issue is for user (and us when they open issue).

This is what we get now for example

$ quarto render --to pdf
Check file:///root/projects/quarto-cli/src/quarto.ts
[1/4] index.qmd
[2/4] intro.qmd
ERROR: Couldn't find open server.
Chrome process error: /root/.local/share/quarto/chromium/linux-869685/chrome-linux/chrome: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory

It will allow us to get more information in bug report like in #1822
@cderv cderv requested a review from cscheid September 19, 2022 15:01
@cscheid
Copy link
Collaborator

cscheid commented Sep 19, 2022

Looks good to me! Can you add an entry to the changelog, though?

@cderv
Copy link
Collaborator Author

cderv commented Sep 19, 2022

Sure - I am guessing changelog 1.2 https://github.com/quarto-dev/quarto-cli/blob/main/news/changelog-1.2.md ?

Still unsure each time I do a PR in which version this goes :)

By the way, I added comment in #1822 and we could make this error more clever by

  • detecting error while loading shared libraries
  • In that case advice to run ldd <path to quarto chrom> | grep not and install missing deps.

But maybe too clever...

@cscheid
Copy link
Collaborator

cscheid commented Sep 19, 2022

main will become 1.2, so that's correct.

@cderv
Copy link
Collaborator Author

cderv commented Sep 19, 2022

main will become 1.2, so that's correct.

ok. Did not have time to add to the file before you merged, but I'll add to it directly.

@cscheid
Copy link
Collaborator

cscheid commented Sep 19, 2022

@cderv Ugh, I'm sorry. Clearly I haven't had enough coffee yet.

cderv added a commit that referenced this pull request Sep 19, 2022
@cderv cderv deleted the chrome-process-error branch September 19, 2022 16:50
cscheid pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants