feat(brand): Allow named weights and numeric values in brand-font-weight
#10737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
brand-font-weight
definition to allow named font weight values and to support variable font weights. Currently the definition limits font weight to1:9 * 100
:but CSS also allows
normal
(400),bold
(700),lighter
, andbolder
. In CSS, the last two are relative font weights and are relative to the element's inherited value. In our case, however, I'd recommend we simply assign these values 100 (lighter
) and 900 (bolder
).Here's the description of
font-weight
as a numeric value from MDN:In HTML outputs, we can pass numeric and named values through and let CSS handle the computation. In places where variable or named font weights aren't supported, I propose we round to the nearest named point (using our definition for lighter and bolder):