_brand.yml: fonts in html-like formats, font colors, schema updates, etc
#10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
reviewed
Sep 6, 2024
cscheid
force-pushed
the
feature/brand-yml-html-fonts
branch
from
496600b
to
598e1f7
Compare
cscheid
changed the title
html-like formatshtml-like formats, font colors, schema updates, etc
gordonwoodhull
force-pushed
the
feature/brand-yml-html-fonts
branch
from
d60ef28
to
a94aa8d
Compare
|
I've updated the typst brand yaml implementation and tests to the new schema. Remaining failures don't seem to be related to brand yaml. I think this is fine to merge. I'll continue with caching of fonts for typst, and hopefully have that ready for review at eng meeting tomorrow. |
|
I've disabled font bunny on the Typst side for now (and removed the failing test), but we can pick it back up if we find a better woff->ttf converter. I think we should merge this once the tests pass. |
Closed
cscheid
force-pushed
the
feature/brand-yml-html-fonts
branch
from
bfbe1c5
to
7bac8f0
Compare
|
I cleaned up all this work into two main commits, one for the SCSS->CSS variable/SCSS analyzer work, and the other for the typography work in typst+html formats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10249.
This adds support for
typographyentries inhtmlformats.Notably, we don't currently download the fonts. I'm not sure it's something we want to do or not in HTML formats (it will be necessary for google font support in
typst)