listjs - correctly patch list.min.js to support special character #10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up on a2e298e which patches list.min.js to fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search. This fixes #10720
|
The fix looks good, but I really think we need a playwright test here to avoid further regressions in the future. |
this update playwright deps too, to get latest testing
|
And new playwright test is passing ! Yeah !! |
|
I backported the change in list.ming.js in 1.5 : e353f59 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on a2e298e which patches
list.min.jsto fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search.This fixes #10720
This wrong patching was done in 1.5.4 initially and introduced a regression. @cscheid I think we can backport in 1.5. I'll add to changelog accordingly.