Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto LaTeX engine improvement on missing package detection #10614

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Aug 27, 2024

  • Don't try installing hyphen package when auto installation
  • Ignore some log entries for missing hyphen packages that don't really exists. (like 'chinese-hans' and 'chinese')

Closes #10291

@cscheid
Copy link
Collaborator

cscheid commented Aug 27, 2024

We should add a regression test here.

@cderv
Copy link
Collaborator Author

cderv commented Aug 27, 2024

yes I need to think about the right testing for this. I don't want our test to hang on CTAN package installation. (because this is what could happen when trying to install a wrong package).

I'll add something before merging. Thanks for the review!

@cderv cderv force-pushed the latex/auto-install-opt-out branch from 811cc07 to ab5ccec Compare August 30, 2024 09:11
@cderv cderv merged commit 81a2834 into main Aug 30, 2024
47 checks passed
@cderv cderv deleted the latex/auto-install-opt-out branch August 30, 2024 14:42
@cderv cderv added this to the v1.6 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarto v1.5 installs a nonexistent package hyphen-chinese-hans when compiling PDF
2 participants