-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
themes: use content hash in cache key and output file name #10611
Conversation
revealjs
themes: use content hash in cache key and output file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice fix for the revealjs problem ! Thanks a lot.
I want to open a discussion on some other change for websites and bootstrap themes. I commented below, but we can also discuss this live - could be easier than in writing here.
I mostly want to make sure I understand correctly the impact, as I though current design choice was Bootstrap website themes should always win.
revealjs
themes: use content hash in cache key and output file name
🔥 awesome and a lot shorter than I expected! |
This fixes one of the longstanding Quarto SCSS bugs with theming.
Now, different files in the same website can have different themes and they will each have their own CSS file.
This currently applies to:
bootstrap.min.css
, which is now emitted asbootstrap-${hash}.min.css
, wherehash
is the MD5 hash of the output. This file is generated byhtml
anddashboard
both.quarto.css
, the name of the css file in revealjs themes.quarto-syntax-highlighting.css
, the CSS file responsible for syntax highlighting.We need unit and regression tests as well as a whole lot of early user testing on this one.
This closes #10369, #10087, #8383 (and likely others that I haven't found)