Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 Changelog Updates: Lua Filters #8301

Open
7 of 11 tasks
cwickham opened this issue Jan 17, 2024 · 5 comments · May be fixed by quarto-dev/quarto-web#1166
Open
7 of 11 tasks

1.4 Changelog Updates: Lua Filters #8301

cwickham opened this issue Jan 17, 2024 · 5 comments · May be fixed by quarto-dev/quarto-web#1166
Assignees
Labels
documentation Doc improvements & quarto-web
Milestone

Comments

@cwickham
Copy link
Collaborator

cwickham commented Jan 17, 2024

Moving from #7906

Leaving up to @cscheid if and where these are documented:

Lua filters

  • Add support for relative paths in require() calls.
  • Add support quarto.doc.add_resource and quarto.doc.add_supporting. add_resource will add a resource file to the current render, copying that file to the same relative location in the output directory. add_supporting will add a supporting file to the current render, moving that file file to the same relative location in the output directory.
  • (#5242): Add line numbers to error messages.
  • (#5461): ensure return type of stripTrailingSpace is always pandoc.List.
  • (#5466): Provide global environment _G to user filters.
  • (#6211): Improve error message when a JSON filter (or a potentially misspelled Lua filter from an extension) is not found.
  • (#6215): Add quarto.utils.string_to_inlines and quarto.utils.string_to_blocks to Lua API to convert a string to a list of inlines or blocks taking into account quarto's AST structure.
  • (#6289): allow markdownToInlines to take empty string.
  • (#6935): Add isGithubMarkdownOutput() to quarto.format API.
  • (#6935): render callouts to gfm using GitHub's syntax.
  • (#7083): Separate custom node handlers for Span and Div nodes, enabling conditional content spans (author: @knuesel)
@cwickham cwickham added the documentation Doc improvements & quarto-web label Jan 17, 2024
@cwickham cwickham added this to the v1.4 milestone Jan 17, 2024
This was referenced Mar 15, 2024
@cwickham cwickham modified the milestones: v1.4, v1.5 Jun 10, 2024
@cwickham
Copy link
Collaborator Author

@cscheid Let's get this closed for 1.5. I'm happy to take a stab if you help me find homes.

I checked off the last one (#7083) since we do document conditional spans as part of Conditional Content.

That leaves:

Add support for relative paths in require() calls.

I'm assuming this belongs somewhere in https://quarto.org/docs/extensions/lua-api.html Maybe as a mention in https://quarto.org/docs/extensions/lua-api.html#lua-base-api?

Add support quarto.doc.add_resource and quarto.doc.add_supporting. add_resource will add a resource file to the current render, copying that file to the same relative location in the output directory. add_supporting will add a supporting file to the current render, moving that file file to the same relative location in the output directory.

These need to go in https://quarto.org/docs/extensions/lua-api.html#quarto-lua-api Do they go:

  • In the table at the start of Dependencies, or
  • In their own subsection of Dependencies, or
  • ?

@cwickham
Copy link
Collaborator Author

On:

Add support for relative paths in require() calls.

Is this describing the same thing: https://quarto.org/docs/prerelease/1.4/lua_changes.html#relative-paths-in-require-calls ? Can we grab this and chuck it wherever we decide from above?

@cscheid
Copy link
Collaborator

cscheid commented Jun 10, 2024

Add support for relative paths in require() calls.

Is this describing the same thing: https://quarto.org/docs/prerelease/1.4/lua_changes.html#relative-paths-in-require-calls ? Can we grab this and chuck it wherever we decide from above?

Yes, and yes.

@mcanouil
Copy link
Collaborator

I don’t see the new LUA filter processing order in this issue or in the main documentation, am I missing something?

@cwickham
Copy link
Collaborator Author

@mcanouil It's in a different issue, but I'll attack them together

@cwickham cwickham modified the milestones: v1.5, v1.6 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Doc improvements & quarto-web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants