Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find homes for changes in 1.4 to LUA and AST #7900

Open
cwickham opened this issue Dec 12, 2023 · 3 comments · May be fixed by quarto-dev/quarto-web#1166
Open

Find homes for changes in 1.4 to LUA and AST #7900

cwickham opened this issue Dec 12, 2023 · 3 comments · May be fixed by quarto-dev/quarto-web#1166
Assignees
Labels
documentation Doc improvements & quarto-web
Milestone

Comments

@cwickham
Copy link
Collaborator

cwickham commented Dec 12, 2023

The changes in LUA and AST processing don't belong in the Guide, but probably belong somewhere in Extensions > Creating Extensions. (We might also consider moving the changes to AST in 1.3)

[Edit: Expanding these three items out by section to make discussion easier]

AST processing changes in v1.4:

Lua filter changes:

AST in 1.3:

  • Custom AST Nodes: Callouts, Tabsets, Conditional Blocks
@cwickham cwickham added the documentation Doc improvements & quarto-web label Dec 12, 2023
@cwickham cwickham added this to the 1.4 milestone Dec 12, 2023
@mcanouil
Copy link
Collaborator

mcanouil commented Dec 12, 2023

I've seen many users using Lua filters without using Quarto extensions mechanism.
I think some users don't know they don't have to write extensions to use a Lua filter (especially all the Lua filters developed initially for Pandoc).

Here the "Extensions" pages should be read as "Extend Quarto with Lua filters, shortcodes formats and possibly distribue as Quarto extensions" but I feel users are reading this as "Use Quarto Extension mechanism", especially since this part starts with a listings of extension followed by how to create extensions.

(my two cents)

FYI, in discussions, there are several simple examples of Lua filters (a lot written by @cscheid):

https://github.com/quarto-dev/quarto-cli/discussions?discussions_q=label%3Alua

@cwickham
Copy link
Collaborator Author

cwickham commented Dec 12, 2023

Ah, that's a really good point. And there are other things that fall into the "customizing output without actually writing an extension" bucket, like using template partials, that we only talk about in the context of creating extensions.

This might need to part of a larger discussion/redesign of the Extensions section.

@cderv cderv modified the milestones: 1.4, v1.4 Dec 13, 2023
@cscheid cscheid self-assigned this Jan 16, 2024
@cwickham
Copy link
Collaborator Author

Related issue #4926

This was referenced Mar 15, 2024
@cwickham cwickham changed the title [1.4 Docs] Find homes for LUA and AST changes Find homes for changes in 1.4 to LUA and AST Mar 17, 2024
@cderv cderv modified the milestones: v1.4, v1.6 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Doc improvements & quarto-web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants