Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf_channel: settle bias current for 1ms before measuring #81

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

jordens
Copy link
Member

@jordens jordens commented Oct 4, 2020

  • close Bias tuning unreliable #66
  • add the AsmDelay to LateResources
  • pass it through from idle() to mqtt_control to booster_channels to
    rf_channel
  • the alternative of Copy AsmDelay and keeping it on each rf_channel
    seemed about as much code and less appealing

This is an untested draft and it's unknown whether it solves #66

* close #66
* add the AsmDelay to LateResources
* pass it through from idle() to mqtt_control to booster_channels to
  rf_channel
* the alternative of Copy AsmDelay and keeping it on each rf_channel
  seemed about as much code and less appealing
@jordens jordens requested a review from ryan-summers October 4, 2020 12:26
Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor documentation clean-up tasks

src/booster_channels.rs Show resolved Hide resolved
src/mqtt_control.rs Show resolved Hide resolved
@jordens jordens requested a review from ryan-summers October 5, 2020 07:35
@ryan-summers ryan-summers merged commit 65d2dd0 into develop Oct 5, 2020
@ryan-summers ryan-summers deleted the feature/delay-1ms-tune-bias branch October 5, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bias tuning unreliable
2 participants