-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/channel settings #68
Conversation
.expect("Failed to configure RF bias voltage"); | ||
|
||
self.pins.signal_on.set_high().unwrap(); | ||
|
||
self.settings.data.enabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change the boot-up configuration here. The enable-on-boot setting should be separate from the enable/disable commands and the latter should not touch that setting. The setting should be (separately) configurable (like the thresholds and transforms).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I think this is already implemented by the save_config
semantics, right? Then scratch it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - settings are only updated in NVM when explicitly requeested to save
over the MQTT control interface.
Right now, the settings are loaded from NVM and propagated to the channel. Then, the settings mirror the current state of the channel so they can be persisted to nvm immediately upon receipt of the save
command - they are not otherwise persisted.
This PR adds in support for persistent channel configuration settings.
This PR fixes #11
I have also added a TXT file containing the EEPROM contents of one of the RF modules for future reference.
The present channel configuration may be persisted to channel EEPROM using the booster utility script:
python booster.py <CH> --save
.The channel configuration is composed of:
Power measurement calibration is deferred to #69
Testing:
python booster.py 0 --save