Implement MQTT-based control interface #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Sep 2, 2020
ryan-summers
commented
Sep 3, 2020
ryan-summers
commented
Sep 3, 2020
| // to re-establish them once we reconnect. | ||
| Err(minimq::Error::Disconnected) => self.subscribed = false, | ||
|
|
||
| Err(e) => panic!("Unexpected error: {:?}", e), |
There was a problem hiding this comment.
I've been observing a spurious error here whenever the MQTT broker is disconnected minimq::Error::Network(Spi(5)) - need to find the root cause before merging.
There was a problem hiding this comment.
This is now tracked in minimq, since the bug is related to minimq's management of W5500 errors.
jordens
approved these changes
Sep 3, 2020
|
@jordens I've done a minor refactor to include the |
jordens
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a control interface to booster over MQTT. Currently, the following topics are used:
booster/enable- Enable a specific RF channelbooster/disable- Disable a specific RF channelbooster/thresholds- Configure interlock thresholds for a specific RF channelbooster/tune- Tune the RF bias current of an enabled channelThis closes #7 by implementing the RF bias current algorithm.
This closes #8 by allowing channel tuning over the MQTT control interface.
This also closes #50 by implementing a fix to the getter function.
TODO:
mqtt_control.rsto place structs and requests/responses near top