-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial MQTT support #48
Conversation
c.device.SPI1, | ||
(sck, miso, mosi), | ||
mode, | ||
1.mhz().into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is set pretty low right now, which can result in slower ethernet throughput. I had it up towards the 30MHz range, but was seeing data corruption, so I dropped it down. Given the long ribbon cable, I'm inclined to leave this low until we have a need to bump it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I checked SPI modes. Agreed to stay at 1 MHz until somebody from the HW development confirms SI and max speed. There are the knobs of tuning the IO speed on the µC, but I don't expect much and wouldn't dive into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
One minor nit.
c.device.SPI1, | ||
(sck, miso, mosi), | ||
mode, | ||
1.mhz().into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I checked SPI modes. Agreed to stay at 1 MHz until somebody from the HW development confirms SI and max speed. There are the knobs of tuning the IO speed on the µC, but I don't expect much and wouldn't dive into it.
This PR addresses #7 by adding initial support of MQTT telemetry reporting via the W5500 TCP/IP stack.