Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial MQTT support #48

Merged
merged 8 commits into from
Sep 2, 2020
Merged

Initial MQTT support #48

merged 8 commits into from
Sep 2, 2020

Conversation

ryan-summers
Copy link
Member

This PR addresses #7 by adding initial support of MQTT telemetry reporting via the W5500 TCP/IP stack.

c.device.SPI1,
(sck, miso, mosi),
mode,
1.mhz().into(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set pretty low right now, which can result in slower ethernet throughput. I had it up towards the 30MHz range, but was seeing data corruption, so I dropped it down. Given the long ribbon cable, I'm inclined to leave this low until we have a need to bump it up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I checked SPI modes. Agreed to stay at 1 MHz until somebody from the HW development confirms SI and max speed. There are the knobs of tuning the IO speed on the µC, but I don't expect much and wouldn't dive into it.

Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
One minor nit.

c.device.SPI1,
(sck, miso, mosi),
mode,
1.mhz().into(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I checked SPI modes. Agreed to stay at 1 MHz until somebody from the HW development confirms SI and max speed. There are the knobs of tuning the IO speed on the µC, but I don't expect much and wouldn't dive into it.

src/main.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers requested a review from jordens September 1, 2020 16:55
@ryan-summers ryan-summers merged commit cd63fa2 into develop Sep 2, 2020
@ryan-summers ryan-summers deleted the feature/ethernet branch September 2, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants