-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated link text for consistency #44192
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
fa6446e
to
e535aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 for the change
I would keep it as is for consistency within the guide, see the official documentation
phrase is used in other places (I count 7 places in https://github.com/quarkusio/quarkus/blob/e535aa62b0021a5324dc4a30348fd617a6b0baa1/docs/src/main/asciidoc/datasource.adoc)
Can you elaborate on "Updated link text for consistency"? consistency with what?
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
e535aa6
to
250f8e7
Compare
Thanks for your feedback @rsvoboda. When I first made this change, I hadn’t noticed the many other instances of “official documentation.” My goal was to add clarity by addressing questions like “Whose official documentation?” (MySQL’s) and “What is the subject of this documentation?” (Connector/J Developer Guide). I agree that this change would benefit from a more comprehensive review and some discussion. With that in mind, I’m closing this PR. |
Updated the link text for user clarity and consistency.