Add apicurio protobuf support #37981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/dependencies
carlesarnal
force-pushed
the
add-apicurio-protobuf-support
branch
from
aa5291d
to
a3af5f8
Compare
|
The problem with the native integration test is that when the test is executed in that mode, the runtime used for generating the class and the one used for running the test is different, causing protobuf to fail validating the message. The flow and test works fine in JVM mode, and that might be all that can be done here. |
carlesarnal
force-pushed
the
add-apicurio-protobuf-support
branch
from
a3af5f8
to
43ebc1d
Compare
This comment has been minimized.
This comment has been minimized.
carlesarnal
force-pushed
the
add-apicurio-protobuf-support
branch
from
a632761
to
5c24e10
Compare
|
@alesj can you have a look? |
|
@cescoffier yeah, already on my todo list for this week -- all coordinated with @carlesarnal |
carlesarnal
force-pushed
the
add-apicurio-protobuf-support
branch
from
5c24e10
to
267407b
Compare
|
@alesj now the error must be reproducible. Note that I had to revert the banned dependency, so I'm going to close the PR for now so it does not get merged by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for serialization using protobuf as #37722 introduced for JSON Schema. The caveat here is that Protobuf serialization does not work for now in native mode. I will investigate more.