Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.4 backports 1 #37815

Merged
merged 13 commits into from
Dec 19, 2023
Merged

3.6.4 backports 1 #37815

merged 13 commits into from
Dec 19, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 18, 2023

Please don't merge, I will merge it myself.

dependabot bot and others added 13 commits December 18, 2023 18:54
Bumps [io.quarkus:quarkus-platform-bom-maven-plugin](https://github.com/quarkusio/quarkus-platform-bom-generator) from 0.0.100 to 0.0.101.
- [Release notes](https://github.com/quarkusio/quarkus-platform-bom-generator/releases)
- [Commits](quarkusio/quarkus-platform-bom-generator@0.0.100...0.0.101)

---
updated-dependencies:
- dependency-name: io.quarkus:quarkus-platform-bom-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 6e1f5a8)
It should be `dev mode` with a space and no capitalization.

(cherry picked from commit 33a4b25)
This is done because the stacktrace
produced is completely useless
and only makes it harder to focus on
the real problem

Relates to: quarkiverse/quarkus-langchain4j#140

(cherry picked from commit 542e93b)
replace MINE type with MIME type

(cherry picked from commit aecf4a6)
This is done because this type exists in Java 21
but not Java 17.

Fixes: quarkusio#37768
(cherry picked from commit 674eac2)
This is necessary for REST Client
MessageBodyReader and MessageBodyWriter
registration

(cherry picked from commit e7fcd32)
Not having this file is probably due to GitHub infra issues but let's
not fail the build for that.

(cherry picked from commit 0f38872)
- we observed NPE in some edge cases during live reload

(cherry picked from commit 3fb7924)
We had a problem here as most options are only valid in the context of
the root command (for instance -D) so trying to parse them in the
context of a subcommand or on their own will most probably fail.

Also parsing recursively the command is non-efficient as we do a lot of
parsing, especially since it was done twice (this was fixed too).

The new approach uses the ParseResult generated once and get the
knownledge from there. From my tests, it provides similar results and
avoid false positives and running the parsing too many times.

This should fix CliHelpTest#testCommandHelp() being flaky as not being
able to interpret the options ended up triggering the missing command
branch and then the JBang support.

(cherry picked from commit fb4a379)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Dec 18, 2023
@gsmet gsmet self-assigned this Dec 18, 2023
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/metrics area/rest labels Dec 18, 2023
Copy link

github-actions bot commented Dec 18, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 18, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 9bca238 into quarkusio:3.6 Dec 19, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/metrics area/rest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants