Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc edits for quarkus-oidc.adoc #37753

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Dec 14, 2023

Purpose: Edit upstream security docs for eventual migration to product.
References: https://issues.redhat.com/browse/QDOCS-557

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member

@rolfedh Hi Rolfe, a lot of good cleanup here, but I'm not sure starting with the Optional. javaDocs prefix everywhere we see the use of Java Optional is that great

@rolfedh rolfedh closed this Dec 19, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 19, 2023
@sberyozkin
Copy link
Member

@rolfedh LGTM, a few minor suggestions are proposed

Copy link
Contributor Author

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks. Please let me know if there are any other issues I can help resolve.

@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member

@rolfedh Please fix the formatting issue

@quarkus-bot

This comment has been minimized.

@sberyozkin sberyozkin added triage/backport-3.8 triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 17, 2024
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 17, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit b0cac4f into quarkusio:main Jan 17, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 17, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 17, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants