Javadoc edits for quarkus-oidc.adoc #37753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
4b95ee4
to
b344581
Compare
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
b344581
to
af9cb58
Compare
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
af9cb58
to
cd9bec4
Compare
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
cd9bec4
to
4fcf064
Compare
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
4fcf064
to
e15ac58
Compare
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
e15ac58
to
72b0a5b
Compare
This comment has been minimized.
This comment has been minimized.
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 15, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 18, 2023
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 18, 2023
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 18, 2023
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Show resolved
Hide resolved
|
@rolfedh Hi Rolfe, a lot of good cleanup here, but I'm not sure starting with the |
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
72b0a5b
to
ace2bbd
Compare
sberyozkin
reviewed
Jan 16, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 16, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 16, 2024
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 16, 2024
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 16, 2024
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 16, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
|
@rolfedh LGTM, a few minor suggestions are proposed |
rolfedh
commented
Jan 16, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
7ac715d
to
e54983b
Compare
This comment has been minimized.
This comment has been minimized.
|
@rolfedh Please fix the formatting issue |
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
e54983b
to
209b748
Compare
sberyozkin
reviewed
Jan 17, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Jan 17, 2024
...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
209b748
to
2bc909c
Compare
sberyozkin
approved these changes
Jan 17, 2024
sberyozkin
added
triage/backport-3.8
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
rolfedh
force-pushed
the
QDOCS-557-ups
branch
from
2bc909c
to
ad6d5e8
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Edit upstream security docs for eventual migration to product.
References: https://issues.redhat.com/browse/QDOCS-557