-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency fixes for Hibernate extensions #37460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, HHH-17362 doesn't fix the problem, and it's unlikely that it will ever be fixed. See https://hibernate.atlassian.net/browse/HHH-17362?focusedCommentId=113465 We'll have to apply annotation processors the "right" way, as explained in https://github.com/hibernate/hibernate-orm/blob/6.3/migration-guide.adoc
… extensions 1. It makes no sense to exclude a transitive dependency if its version is managed and we re-declare that dependency ourselves two lines below. 2. jakarta.xml.bind-api and jakarta.activation-api are not banned at all, are actually transitive dependencies of hibernate-core and hibernate-jpamodelgen, and have their version managed in our BOM. So there's no need to exclude these transitive dependencies or to declare them when we don't use them directly. 3. jakarta.activation-api is a dependency of jakarta.xml.bind-api, so there's no point excluding jakarta.activation-api if the same module is going to depend on jakarta.xml.bind-api. 4. org.jboss:jandex (old artifact) is no longer a dependency of Hibernate ORM, so we don't need to exclude it. 5. io.smallrye:jandex (new artifact) is never required as a runtime dependency of Hibernate ORM, so it should be excluded directly in the BOM.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
approved these changes
Dec 2, 2023
<groupId>org.eclipse.angus</groupId> | ||
<artifactId>angus-activation</artifactId> | ||
<scope>provided</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these were leftovers of when we weren't using these artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dependencies
Pull requests that update a dependency file
area/hibernate-orm
Hibernate ORM
area/hibernate-search
Hibernate Search
area/panache
area/persistence
OBSOLETE, DO NOT USE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first item will likely require that we open an issue, because critically, it means Quarkus users can't rely on the BOM to apply, since the BOM doesn't manage Maven's
<annotationProcessorPaths>
andhibernate-orm.version
doesn't get propagated to POMs using our BOM.Not sure about changes in the second commit, but let's CI what CI has to say.
Properly apply annotation processors in Panache-Hibernate extensions
Unfortunately, HHH-17362 doesn't fix the problem,
and it's unlikely that it will ever be fixed.
See https://hibernate.atlassian.net/browse/HHH-17362?focusedCommentId=113465
We'll have to apply annotation processors the "right" way, as explained
in https://github.com/hibernate/hibernate-orm/blob/6.3/migration-guide.adoc
Fix some wonky dependency exclusions in Hibernate ORM/Reactive/Search extensions
is managed and we re-declare that dependency ourselves two lines
below.
all, are actually transitive dependencies of hibernate-core and
hibernate-jpamodelgen, and have their version managed in our BOM.
So there's no need to exclude these transitive dependencies
or to declare them when we don't use them directly.
so there's no point excluding jakarta.activation-api if the same
module is going to depend on jakarta.xml.bind-api.
so we don't need to exclude it.
of Hibernate ORM, so it should be excluded directly in the BOM.