-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop removing org.graalvm.polyglot:polyglot
artifact from native classpath
#37423
Stop removing org.graalvm.polyglot:polyglot
artifact from native classpath
#37423
Conversation
When quarkusio#35873 was merged `org.graalvm.polyglot:polyglot` was part of the GraalVM dev builds/releases, but was later completely removed from them.
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
org.graalvm.polyglot:polyglot
was never shipped with GraalVMorg.graalvm.polyglot:polyglot
was never shipped with GraalVM
org.graalvm.polyglot:polyglot
was never shipped with GraalVMorg.graalvm.polyglot:polyglot
artifact from native classpath
@jerboaa can you please review this? |
@zakkak Could you please trigger a mandrel/GraalVM CE CI for this? That installs the maven artefacts locally and the quarkus build will use it. I'd like to see this won't cause issues. Thanks! |
Looking at So not sure why you said it was never shipped... |
It's no longer shipped as part of GraalVM CE or Mandrel, it's shipped as a maven artifact only. As a result we no longer need to remove it from the classpath (since it won't be double). |
I scheduled a Mandrel |
Ah, OK. Got it now. Happy to approve. Please only merge if mandrel CI looks good too. |
Well that should have been JDK 22/ea... new workflow https://github.com/graalvm/mandrel/actions/runs/7047225889 |
Mandrel CI looks good. Waiting for Quarkus CI. |
Failing Jobs - Building 224e9dd
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 21 #- Failing: integration-tests/virtual-threads/grpc-virtual-threads
📦 integration-tests/virtual-threads/grpc-virtual-threads✖
|
Test failure is irrelevant. |
When #35873 was merged
org.graalvm.polyglot:polyglot
was part of the GraalVM devbuilds/releases, but was later completely removed from them.