Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate prometheus ServiceMonitor CR #37123

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Nov 15, 2023

Currently, we use Prometheus annotation, but it's recommended to use ServiceMonitor instead.
This pull request enables OOTB ServiceMonitor generation with the option to disable it.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Nov 15, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 16, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@iocanel iocanel requested a review from geoand November 16, 2023 06:15
@iocanel iocanel merged commit 2c45aa6 into quarkusio:main Nov 16, 2023
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants